git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/4] configure: remove checking for HMAC_CTX_cleanup

From
Kazuki Yamaguchi <k@rhe.jp>
Date
Apr 8, 2016, 16:22 UTC
Message-ID
<ad0647c1b135ce2fb21daae35a45209715d7ebbc.1460130092.git.k@rhe.jp>
In-Reply-To
<cover.1460130092.git.k@rhe.jp>
We don't need it, as we no longer use HMAC_CTX_cleanup() directly.
Signed-off-by: Kazuki Yamaguchi <k@rhe.jp>
---
 Makefile          | 6 ------
 configure.ac      | 4 ----
 git-compat-util.h | 3 ---
 3 files changed, 13 deletions(-)
diff --git a/Makefile b/Makefile
index 2742a6977c6a..47ccb0042591 100644
--- a/Makefile
+++ b/Makefile
@@ -355,9 +355,6 @@ all::
 #
 # Define HAVE_CLOCK_MONOTONIC if your platform has CLOCK_MONOTONIC in librt.
 #
-# Define NO_HMAC_CTX_CLEANUP if your OpenSSL is version 0.9.6b or earlier to
-# cleanup the HMAC context with the older HMAC_cleanup function.
-#
 # Define USE_PARENS_AROUND_GETTEXT_N to "yes" if your compiler happily
 # compiles the following initialization:
 #
@@ -1138,9 +1135,6 @@ ifndef NO_OPENSSL
 	ifdef NEEDS_CRYPTO_WITH_SSL
 		OPENSSL_LIBSSL += -lcrypto
 	endif
-	ifdef NO_HMAC_CTX_CLEANUP
-		BASIC_CFLAGS += -DNO_HMAC_CTX_CLEANUP
-	endif
 else
 	BASIC_CFLAGS += -DNO_OPENSSL
 	BLK_SHA1 = 1
diff --git a/configure.ac b/configure.ac
index 0cd9f4680b84..c27902574734 100644
--- a/configure.ac
+++ b/configure.ac
@@ -970,10 +970,6 @@ AC_CHECK_LIB([iconv], [locale_charset],
                      [CHARSET_LIB=-lcharset])])
 GIT_CONF_SUBST([CHARSET_LIB])
 #
-# Define NO_HMAC_CTX_CLEANUP=YesPlease if HMAC_CTX_cleanup is missing.
-AC_CHECK_LIB([crypto], [HMAC_CTX_cleanup],
-	[], [GIT_CONF_SUBST([NO_HMAC_CTX_CLEANUP], [YesPlease])])
-#
 # Define HAVE_CLOCK_GETTIME=YesPlease if clock_gettime is available.
 GIT_CHECK_FUNC(clock_gettime,
 	[HAVE_CLOCK_GETTIME=YesPlease],
diff --git a/git-compat-util.h b/git-compat-util.h
index 474395471f62..1f8b5f3b1f1a 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -279,9 +279,6 @@ extern char *gitdirname(char *);
 #endif
 #include <openssl/ssl.h>
 #include <openssl/err.h>
-#ifdef NO_HMAC_CTX_CLEANUP
-#define HMAC_CTX_cleanup HMAC_cleanup
-#endif
 #endif
 
 /* On most systems <netdb.h> would have given us this, but
-- 
2.8.1.104.g0d1aca6
Previous: Kazuki Yamaguchi
Message 5 of 5 in “fix compilation with OpenSSL 1.1.0-pre4”
  1. 0/4 fix compilation with OpenSSL 1.1.0-pre4Kazuki Yamaguchi, Apr 8, 2016
  2. 1/4 imap-send: use HMAC() function provided by OpenSSLKazuki Yamaguchi, Apr 8, 2016
  3. 2/4 imap-send: check NULL return of SSL_CTX_new()Kazuki Yamaguchi, Apr 8, 2016
  4. 3/4 imap-send: avoid deprecated TLSv1_method()Kazuki Yamaguchi, Apr 8, 2016
  5. 4/4 configure: remove checking for HMAC_CTX_cleanupKazuki Yamaguchi, Apr 8, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.