Re: [PATCH v2 05/20] merge-ort: add an err() function similar to one from merge-recursive
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Nov 11, 2020, 17:10 UTC
- Message-ID
- <acb6291f-a9a4-6c74-61ab-77aa6e7bfc77@gmail.com>
- In-Reply-To
- <CABPp-BER+nzGb42fB2__tF=a8Y-JQ-Fzi8PZ9T6nWG-5RZfzhA@mail.gmail.com>
On 11/11/2020 12:07 PM, Elijah Newren wrote:
Show 13 quoted lines
> On Wed, Nov 11, 2020 at 5:58 AM Derrick Stolee <stolee@gmail.com> wrote: >> This seems simple enough to have a duplicate copy lying >> around. Do you anticipate that all common code will live >> in the same file eventually? Or will these two static err() >> method always be duplicated? > > I anticipate that merge-recursive.[ch] will be deleted. > > merge-ort was what I wanted to modify merge-recursive.[ch] to be, but > Junio suggested doing it as a different merge backend since it had > invasive changes, so that we could have an easy way to try it out and > fallback to the known good algorithm until we had sufficient comfort > with the new algorithm to switch over to it.
OK, I missed that context. Your approach is fine as long as these are not going to both exist forever.
Thanks, -Stolee