Re: [PATCH] wrapper: add workaround for open() returning EINTR

From: Johannes Sixt <j6t@kdbg.org>
Date: Feb 24, 2021, 07:20 UTC
Message-ID: <acb282ee-fc55-bbe0-8272-087bde180ea2@kdbg.org>
In-Reply-To: <YDXZY8XFRayiM1If@coredump.intra.peff.net>

Am 24.02.21 um 05:43 schrieb Jeff King:

Show 5 quoted lines

> The workaround here is enabled all the time, without a Makefile knob,
> since it's a complete noop if open() never returns EINTR. I did push it
> into its own compat/ source file, though, since it has to #undef our
> macro redirection. Putting it in a file with other code risks confusion
> if more code is added after that #undef.

I'm not so much opposed to "enable it all the time" in general, but when we already have an override of open(), like for the Windows case in compat/mingw.h, I find it a bit rough to put another wrapper around it, even more so since we won't have the EINTR problem on Windows due to the absence of signals.

-- Hannes