Re: Assertion in git log graphing [regression in v2.25]

From: Derrick Stolee <stolee@gmail.com>
Date: Jan 7, 2020, 14:43 UTC
Message-ID: <ac6d3172-699e-5a61-fa60-420980c49fad@gmail.com>
In-Reply-To: <39277f9a-f88d-94a3-2a8b-b6e0a3dfdc62@gmail.com>

On 1/7/2020 9:22 AM, Derrick Stolee wrote:

Show 13 quoted lines

> Note how 6_M4 has three parents, and the first parent has a horizontal
> edge. Even giving an extra padding line between horizontal edges, we
> _could_ output the following instead:
> 
> 
> | | | | | | *   6_M4
> | |_|_|_|_|/|\
> |/| | | | |/ /
> | | |_|_|/| /
> | |/| | | |/
> | | | |_|/|
> | | |/| | |
> | | * | | | 6_G

I should have tested this example with v2.24.1, which gives this output in this section:

| | | | | | *-.   6_M4
| | | | | | |\ \  
| |_|_|_|_|/ / /  
|/| | | | | / /   
| | |_|_|_|/ /    
| |/| | | | /     
| | | |_|_|/      
| | |/| | |       
| | * | | | 6_G

So, this is likely the behavior we would prefer.

For the release, it is likely best to keep the change that does not collapse properly and fix this collapse bug later. (It is likely an invasive change.)

Thanks, -Stolee