Re: [GSoC] My Git Dev Blog - Week 5

From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date: Jun 20, 2021, 19:16 UTC
Message-ID: <ac381db1-fb14-2a23-cfee-863840b89493@gmail.com>
In-Reply-To: <D32894F5-FC76-4DD2-A2F6-E69AAE88C645@gmail.com>

On 19/06/21 7:02 pm, Atharva Raykar wrote:

> Here's the latest instalment of my weekly Git blog:
> http://atharvaraykar.me/gitnotes/week5
>

Nice blog.

Show 10 quoted lines

> A peek at what's inside:
> 
>   * The blog starts with a summary of all the relevant things
>     that have happened so far in my time with Git, including
>     the status of my submodule-related work.
> 
>   * A question I had about reading the index into memory
>     (any kind of help would be appreciated!):
>     http://atharvaraykar.me/gitnotes/week5#some-challenges-with-the-changes-that-are-cooking
>

I've tried to clarify this to an extent in a comment [1] on your branch.

A few other things:

> After Rafael and Eric commented on my patch, I forgot to CC them when
> I rerolled. New contributors: please check your CC’s before hitting send!

To add to that, Cc-ing people in the e-mail of all the patches in the series and not just in the cover letter would be nice too. :) Of course, if you have a specific reason to not do that, then it's fine.

> And my other blooper was to forget signing off one of my patches. Oops.

Are you aware of `format.signOff` [2] which could save you from issues like these?

[1]: https://github.com/tfidfwastaken/git/commit/3c46c108a195c42edaab939ab6dd6731e52aefc3#r52396546

[2]: https://git-scm.com/docs/git-config#Documentation/git-config.txt-formatsignOff

-- 
Sivaraam