Re: [PATCH 1/1] shallow: fix relative deepen on non-shallow repositories

From: René Scharfe <l.s.r@web.de>
Date: May 11, 2026, 07:45 UTC
Message-ID: <ac1aac76-17bc-469b-8dc1-d3a384f5c6af@web.de>
In-Reply-To: <xmqqzf26x0vi.fsf@gitster.g>

On 5/11/26 2:09 AM, Junio C Hamano wrote:

Show 6 quoted lines

> 
> We obviously should not truncate when asked to "deepen" (i.e., the
> user asked to get more history, not reset the number of commits we
> have to a specific depth), and making the operation in this
> situation a no-op may be a good first step, but should we just do so
> silently, instead of giving a warning/diagnosis?

Perhaps, but no warning has been given for deepening a non-shallow repo since the introduction of this option by cccf74e2da (fetch, upload-pack: --deepen=N extends shallow boundary by N commits, 2016-06-12).

The best place for such a warning would be close to the user, in fetch, no? And in its own patch.

René