Re: [PATCH v2 3/7] odb: update `struct odb_write_stream` read() callback
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Apr 1, 2026, 11:23 UTC
- Message-ID
- <ac0AOEonqMnA20A1@pks.im>
- In-Reply-To
- <20260401030316.1847362-4-jltobler@gmail.com>
On Tue, Mar 31, 2026 at 10:03:11PM -0500, Justin Tobler wrote:
> The `read()` callback used by `struct odb_write_stream` currently > returns a pointer to an internal buffer along with the number of bytes > read. This makes buffer ownership unclear and provides no way to report > errors.
Not only that, but it also means that it's impossible for the caller to control the chunk size.
The changes all look straight-forward to me.
Patrick