Re: [PATCH] Fix git rev-list --reverse --max-count=N

From: Michael Spang <spang@google.com>
Date: Jan 27, 2010, 22:21 UTC
Message-ID: <abef960f1001271421s6c0f72f7xd2697ab34b53d1ea@mail.gmail.com>
In-Reply-To: <201001272309.26054.j6t@kdbg.org>

On Wed, Jan 27, 2010 at 5:09 PM, Johannes Sixt <j6t@kdbg.org> wrote:

Show 21 quoted lines

> On Mittwoch, 27. Januar 2010, Michael Spang wrote:
>
> So when you have this history (A is oldest, D is newest):
>
>   A--B--C--D
>
> and you say
>
>   git log --max-count=2 --reverse D
>
> then you want
>
>   A
>   B
>
> but I want
>
>   C
>   D
>
> Why is your interpretation correct, an mine wrong?

Perhaps not wrong, but for me it was unexpected. For whatever reason, I expected "--reverse" to give you the illusion that you are iterating from the beginning of the history, even if it's not actually possible to iterate that way directly. In line with that, limiting the output to N commits would give you the earliest N commits. If you instead think "stop descending through the history once we have N commits" the current behavior makes sense.

I talked to Junio and he says the current behavior is here to stay.

Michael