git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/3] p7821: fix instructions for testing with threads

From
Philippe Blain via GitGitGadget <gitgitgadget@gmail.com>
Date
Apr 12, 2025, 18:15 UTC
Message-ID
<abd146b7c2a62aaef5c22269cff155387f33fe32.1744481732.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1936.v2.git.git.1744481732.gitgitgadget@gmail.com>
From: Philippe Blain <levraiphilippeblain@gmail.com>

In 7b31b55db1 (perf: amend the grep tests to test grep.threads, 2017-12-29), p7821 was tweaked to test the performance of 'git grep' under different number of threads. These tests are run if GIT_PERF_GREP_THREADS is set to a list of thread numbers, but the comment at the top of the file instead mentions GIT_PERF_7821_THREADS. Fix the comment.

Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
---
 t/perf/p7821-grep-engines-fixed.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/perf/p7821-grep-engines-fixed.sh b/t/perf/p7821-grep-engines-fixed.sh
index 1d126c7b039..66bec284e3b 100755
--- a/t/perf/p7821-grep-engines-fixed.sh
+++ b/t/perf/p7821-grep-engines-fixed.sh
@@ -7,7 +7,7 @@ git-grep. Make sure to include a leading space,
 e.g. GIT_PERF_7821_GREP_OPTS=' -w'. See p7820-grep-engines.sh for more
 options to try.
 
-If GIT_PERF_7821_THREADS is set to a list of threads (e.g. '1 4 8'
+If GIT_PERF_GREP_THREADS is set to a list of threads (e.g. '1 4 8'
 etc.) we will test the patterns under those numbers of threads.
 "
 
-- 
gitgitgadget
Previous: Philippe Blain via GitGitGadgetNext: Junio C Hamano
Message 10 of 13 in “Two perf test fixes”
  1. 0/2 Two perf test fixesPhilippe Blain via GitGitGadget, Mar 28, 2025
  2. 1/2 p7821: fix test_perf invocation for prereqsPhilippe Blain via GitGitGadget, Mar 28, 2025
  3. Patrick SteinhardtMar 31, 2025
  4. Philippe BlainApr 13, 2025
  5. 2/2 p9210: fix 'scalar clone' when running from a detached HEADPhilippe Blain via GitGitGadget, Mar 28, 2025
  6. Patrick SteinhardtMar 31, 2025
  7. 0/3 Two perf test fixesPhilippe Blain via GitGitGadget, Apr 12, 2025
  8. 1/3 p7821: fix test_perf invocation for prereqsPhilippe Blain via GitGitGadget, Apr 12, 2025
  9. 2/3 p9210: fix 'scalar clone' when running from a detached HEADPhilippe Blain via GitGitGadget, Apr 12, 2025
  10. 3/3 p7821: fix instructions for testing with threadsPhilippe Blain via GitGitGadget, Apr 12, 2025
  11. Junio C HamanoApr 14, 2025
  12. Philippe BlainApr 13, 2025
  13. Junio C HamanoApr 14, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.