Re: [PATCH 3/4] imap-send: remove two string length checks

From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Date: Mar 11, 2026, 13:41 UTC
Message-ID: <abFw7FMAwHPPWOBT@ugly.lan>
In-Reply-To: <20260311121107.1122387-4-dev+git@drbeat.li>

On Wed, Mar 11, 2026 at 01:11:06PM +0100, Beat Bolli wrote:

>At this point, these two checks verify that the ASN1_STRINGs are
>internally consistent. This may have been ok when the fields were
>accessed directly, but now that the API is used, is unnecessary.
>

that argumentation makes no sense. the purpose of this check is to ensure that there are no embedded nulls, which the matcher would be unable to deal with, which may be a security hole.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.