git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/3] grep: perform some minor code and comment cleanups

From
DSDragan Simic <dsimic@manjaro.org>
Date
Mar 25, 2024, 21:17 UTC
Message-ID
<ab5145b696565ba170c90e2fc1b9a7e1@manjaro.org>
In-Reply-To
<xmqq5xxahvmi.fsf@gitster.g>
On 2024-03-25 22:03, Junio C Hamano wrote:
Show 11 quoted lines
> Dragan Simic <dsimic@manjaro.org> writes:
> 
>> Move some variable definitions around, and reflow one comment block, 
>> to
>> make the code a bit neater after spotting those slightly unpolished 
>> areas.
>> There are no functional changes to the source code.
> 
> It cannot be objectively better than the original as "neater" and
> 'unpolished" are fairly subjective.  Let's leave this out and take
> the two "obviously good" documentation improvements for now.

That's fine with me. This "experiment", so to speak, has also taught me not to pay attention to making the code "neater".

Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 11 in “Assorted improvements salvaged from an earlier series”
  1. 0/3 Assorted improvements salvaged from an earlier seriesDragan Simic, Mar 24, 2024
  2. 1/3 grep: perform some minor code and comment cleanupsDragan Simic, Mar 24, 2024
  3. Junio C HamanoMar 25, 2024
  4. Dragan SimicMar 25, 2024
  5. Junio C HamanoMar 25, 2024
  6. 2/3 grep docs: describe --recurse-submodules further and improve formatting a bitDragan Simic, Mar 24, 2024
  7. Junio C HamanoMar 25, 2024
  8. Dragan SimicMar 25, 2024
  9. 3/3 grep docs: describe --no-index further and improve formatting a bitDragan Simic, Mar 24, 2024
  10. Junio C HamanoMar 25, 2024
  11. Dragan SimicMar 25, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.