git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git am/mailinfo: Don't look at in-body headers when rebasing

From
Philip Hofstetter <phofstetter@sensational.ch>
Date
Nov 18, 2009, 23:47 UTC
Message-ID
<aa2993680911181547p4cbbf12cq74b482f63e59d007@mail.gmail.com>
In-Reply-To
<4B0478ED.30306@gmail.com>
Hi,
On Wed, Nov 18, 2009 at 11:45 PM, Lukas Sandström <luksan@gmail.com> wrote:
> The actual change is that mailinfo doesn't look for in-body headers
> at all if --no-inbody-headers is passed. git-am now passes this option
> to mailinfo when rebasing.

after all the earlier discussion and a lot of thinking, I have to say, that IMHO, this is the best option as it doesn't rely on heuristics and now that you chose a descriptive command line switch, even the small problem of "why exactly is this switch here?" seems to go away.

As I have no experience in git's codebase at all, I'll leave the commenting on the patch itself to the people with clue, but conceptionally, this feels much better than the method 1

> This won't handle the case when a "bad" patch is passed to git-am from
> somewhere else than git rebase.

of course, that leaves the question what "somewhere else" can contain. If it's just manual calls to git-am, this is a non-issue as it's easily fixed by the caller. If it's being called from other higher-level operations though, you might run into the same issue again.

Here too, I can't really provide any meaningful input though as I just don't know well enough what really makes git tick.

Just my two cents :-)
Philip
Previous: Lukas SandströmNext: Lukas Sandström
Message 5 of 13 in “git-mailinfo doesn't stop parsing at the end of the header”
  1. Philip HofstetterNov 18, 2009
  2. Jeff KingNov 18, 2009
  3. Jeff KingNov 18, 2009
  4. git am/mailinfo: Don't look at in-body headers when rebasingLukas Sandström, Nov 18, 2009
  5. Philip HofstetterNov 18, 2009
  6. git am/mailinfo: Don't look at in-body headers when rebasingLukas Sandström, Nov 19, 2009
  7. Jeff KingNov 19, 2009
  8. git am/mailinfo: Don't look at in-body headers when rebasingLukas Sandström, Nov 20, 2009
  9. Philip HofstetterNov 18, 2009
  10. Jeff KingNov 18, 2009
  11. Jakub NarebskiNov 18, 2009
  12. Jeff KingNov 18, 2009
  13. Philip HofstetterNov 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.