git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t/t5319-multi-pack-index.sh: drop early 'test_done'

From
Patrick Steinhardt <ps@pks.im>
Date
Jan 13, 2026, 07:37 UTC
Message-ID
<aWX2HSakgzcfi-CL@pks.im>
In-Reply-To
<9c5faa5932cdd9e570406bc85ba27f94195a4d3d.1768261435.git.me@ttaylorr.com>
On Mon, Jan 12, 2026 at 06:45:03PM -0500, Taylor Blau wrote:
Show 13 quoted lines
> diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh
> index 794f8b5ab4e..b6622849db7 100755
> --- a/t/t5319-multi-pack-index.sh
> +++ b/t/t5319-multi-pack-index.sh
> @@ -415,8 +415,6 @@ test_expect_success 'up-to-date multi-pack-index is retained' '
>  	)
>  '
>  
> -test_done
> -
>  test_expect_success 'verify multi-pack-index success' '
>  	git multi-pack-index verify --object-dir=$objdir
>  '
Oh dear, this is embarassing.
Patrick
Previous: Taylor BlauNext: Taylor Blau
Message 3 of 5 in “midx-write.c: do not optimize out writes with corrupt MIDXs”
  1. 0/2 midx-write.c: do not optimize out writes with corrupt MIDXsTaylor Blau, Jan 12, 2026
  2. 1/2 t/t5319-multi-pack-index.sh: drop early 'test_done'Taylor Blau, Jan 12, 2026
  3. Patrick SteinhardtJan 13, 2026
  4. 2/2 midx-write.c: assume checksum-invalid MIDXs require an updateTaylor Blau, Jan 12, 2026
  5. Patrick SteinhardtJan 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.