Re: [PATCH v10 4/8] replay: support empty commit ranges
On Mon, Jan 12, 2026 at 10:00:27PM -0800, Elijah Newren wrote:
Show 20 quoted lines
> On Mon, Jan 12, 2026 at 6:17 AM Patrick Steinhardt <ps@pks.im> wrote:
> >
> > In a subsequent commit we're about to introduce a new user of the replay
> > subsystem. With that new user, the range of commits that we'll want to
> > replay will be identified implicitly via "HEAD". With such implicit
> > ranges it becomes likely that the range of revisions that we're asked to
> > replay becomes empty. This case does not make sense with git-replay(1),
> > but with the new command it will.
>
> I think I know what you were trying to say, but this feels misleading;
> it could be the commit at the tip of any branch, not just HEAD.
> Perhaps:
>
> In a subsequent commit we're about to introduce a new user of the replay
> subsystem. With that new user, the range of commits that we'll want to
> replay will be identified implicitly via a single commit, and will
> include all descendants of that commit to any branch. If that commit has
> no descendants (because it's the tip of some branch), then the range of
> revisions that we're asked to replay becomes empty. This case does not
> make sense with git-replay(1), but with the new command it will.
That reads better indeed, thanks!
Patrick