Re: [Bug] hook: -Wanalyzer-deref-before-check warning in run_hooks_opt

From: Patrick Steinhardt <ps@pks.im>
Date: Jan 9, 2026, 16:18 UTC
Message-ID: <aWEqbqPRq5Ie9XTo@pks.im>
In-Reply-To: <7BD989A0-30B1-418E-9257-1731724DCB72@gmail.com>

On Fri, Jan 09, 2026 at 11:02:40AM -0500, Ben Knoble wrote:

Show 11 quoted lines

> 
> > Le 9 janv. 2026 à 06:31, Patrick Steinhardt <ps@pks.im> a écrit :
> 
> [snip]
> 
> > And we'd reliably
> > segfault anyway if we dereference the pointer, even though we would not
> > get a clean error message. Not sure whether that really is worth the
> > hassle though.
> 
> I think you’re probably right in practice, but doesn’t the standard just say dereferencing a NULL pointer is undefined behavior? Just wondering for my own curiosity :)

It is, yeah. But I'd claim that on almost all platforms out there it would segfault anyway.

Patrick