Re: [PATCH] config.mak.uname: use iconv from Homebrew on macOS
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Dec 10, 2025, 23:10 UTC
- Message-ID
- <aTn92yqtSDyVoLgh@fruit.crustytoothpaste.net>
- In-Reply-To
- <16efc726-34be-44f5-aa92-4e82b663ab3d@web.de>
On 2025-12-09 at 19:35:34, René Scharfe wrote:
Show 9 quoted lines
> The library function iconv(3) supplied with macOS versions 15.7.2 > (Sequoia) and 26.1 (Tahoe) is unreliable when doing conversions from > ISO-2022-JP to UTF-8 in multiple steps; t3900 reports this breakage: > > not ok 17 - ISO-2022-JP should be shown in UTF-8 now > not ok 25 - ISO-2022-JP should be shown in UTF-8 now > not ok 38 - commit --fixup into ISO-2022-JP from UTF-8 > > As a workaround, use libiconv from Homebrew, if available.
I like this solution, since it means when Apple ships their own Git (which doesn't use Homebrew), they will be incentivized to fix the problem since the test fails.
-- brian m. carlson (they/them) Toronto, Ontario, CA