Re: [PATCH v8 2/3] fetch: fix non-conflicting tags not being committed

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 1, 2025, 12:58 UTC
Message-ID: <aS2Q4-U5kgJ2nNVv@pks.im>
In-Reply-To: <20251121-fix-tags-not-fetching-v8-2-23b53a8a8334@gmail.com>

On Fri, Nov 21, 2025 at 12:13:46PM +0100, Karthik Nayak wrote:

Show 5 quoted lines

> diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
> index b7059cccaa..4b113d7c27 100755
> --- a/t/t5510-fetch.sh
> +++ b/t/t5510-fetch.sh
> @@ -1577,6 +1578,67 @@ test_expect_success REFFILES 'D/F conflict on case sensitive filesystem with loc

[snip]

Show 13 quoted lines

> +test_expect_success "backfill tags when providing a refspec" '
> +	test_when_finished rm -rf source target &&
> +
> +	git init source &&
> +	git -C source commit --allow-empty --message common &&
> +	git clone file://"$(pwd)"/source target &&
> +	(
> +	    cd source &&
> +	    test_commit history &&
> +	    test_commit fetch-me
> +	) &&
> +
> +	# The "history" tag is backfilled eventhough we requested

Tiny nit, not worth a reroll: s/eventhough/even though/. Other than that this patch looks good to me.

Patrick