Re: [PATCH] replay: do not copy "gpgsign-sha256" header

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 1, 2025, 09:18 UTC
Message-ID: <aS1dcz6i5_phTUEG@pks.im>
In-Reply-To: <xmqqh5ugog2l.fsf@gitster.g>

On Wed, Nov 26, 2025 at 09:32:18AM -0800, Junio C Hamano wrote:

Show 17 quoted lines

> Phillip Wood <phillip.wood123@gmail.com> writes:
> 
> > From: Phillip Wood <phillip.wood@dunelm.org.uk>
> >
> > When "git replay" replays a commit it copies the extended headers
> > across from the original commit. However, if the original commit
> > was signed, we do not want to copy the header associated with the
> > signature is it wont be valid for the new commit. The code already
> > knows to avoid coping the "gpgsig" header but does not know to avoid
> > copying the "gpgsig-sha256" header.  Add that header to the list of
> > exclusions to match what "git commit --amend" does.
> >
> > Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
> > ---
> > We should perhaps think about how we can centralize this list of
> > exclusions as we now have three copies of it in builtin/commit.c,
> > builtin/replay.c and sequencer.c.

Yeah, that would make sense indeed. We've currently got three different versions of this array in "builtin/replay.c", "builtin/commit.c" and in "sequencer.c". Furthermore, we've got `gpg_sig_headers` declared as a variable in `commit.c`, but that one is a bit different.

Anyway, the patch itself is an obvious improvement and bug fixg, so improving the maintainability is certainly something we can leave for a future patch series. #leftoverbits

Show 6 quoted lines

> > This patch is based on maint to make it easier to backport.
> > Unfortunately that means it conflicts with ps/history which moves the
> > code that's changed here to a new file. I'm happy to rebase on on top
> > of that branch if we decide it is not worth backporting this.
> 
> I'd rather give priority to fixes over new development.

I'll make sure to rebase git-history(1) on top of your patch in the next version.

Thanks!

Patrick