Re: [PATCH 0/2] Organize mingw includes
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 10, 2025, 09:53 UTC
- Message-ID
- <aOjXjEJePkpCDoI3@pks.im>
- In-Reply-To
- <pull.1985.git.1759995961.gitgitgadget@gmail.com>
On Thu, Oct 09, 2025 at 07:45:59AM +0000, Johannes Schindelin via GitGitGadget wrote:
> Following in the footsteps of the many, many recent #include refactorings, > this patch series orders the #include statements in compat/mingw.c.
Both of these patches look good to me and I like the improved consistency that they bring. I may also do the same for our code in "refs/", where some of the files use relative includes, as well. Might be worth to document this somewhere if it isn't already, but that doesn't have to be part of your patch series here.
Sorting them also makes sense. It's another thing where I wish that we had a tool to enforce this. clang-format supports this in theory, but it's disabled right now. And I'm not even sure whether it can be told to include e.g. "git-compat-util.h" first.
Thanks!
Patrick