git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] string-list: allow passing NULL for `get_entry_index`

From
shejialuo <shejialuo@gmail.com>
Date
Sep 15, 2025, 12:08 UTC
Message-ID
<aMgBqnwKSKDC5g0I@ArchLinux>
In-Reply-To
<xmqq5xdsyjoz.fsf@gitster.g>
On Mon, Sep 08, 2025 at 09:48:12AM -0700, Junio C Hamano wrote:
Show 21 quoted lines
> shejialuo <shejialuo@gmail.com> writes:
> 
> > Callers of `get_entry_index()` are required to pass a non-NULL
> > `exact_match` parameter to receive information about whether an exact
> > match is found. However, in some cases, callers only need the index
> > position.
> >
> > Let's allow callers to pass NULL for the `exact_match` parameter
> > when they don't need this information, reducing unnecessary variable
> > declarations in calling code.
> >
> > Signed-off-by: shejialuo <shejialuo@gmail.com>
> > ---
> >  string-list.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> I do not quite see the point of adding these conditional assignments
> to clutter the control flow.  What benefit do these callers gain by
> not having to have a throw-away int variable on the stack and
> passing its address to the call chain?
> 

I want to make the commit small. However, I have introduced confusion to the reviewers. I would rebase the first commit and second commit into one commit to improve this.

Thanks, Jialuo

Previous: Ben Knoble
Message 6 of 6 in “string-list: allow passing NULL for `get_entry_index`”
  1. 1/4 string-list: allow passing NULL for `get_entry_index`shejialuo, Sep 7, 2025
  2. Junio C HamanoSep 8, 2025
  3. Ben KnobleSep 10, 2025
  4. Junio C HamanoSep 10, 2025
  5. Ben KnobleSep 10, 2025
  6. shejialuoSep 15, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.