Re: [PATCH 1/6] blame: drop explicit check for commit graph

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 11, 2025, 22:09 UTC
Message-ID: <aMNIhquknyCSquvf@nand.local>
In-Reply-To: <20250904-b4-pks-commit-graph-via-source-v1-1-d932c2481e1a@pks.im>

On Thu, Sep 04, 2025 at 02:49:55PM +0200, Patrick Steinhardt wrote:

Show 14 quoted lines

> diff --git a/blame.c b/blame.c
> index f1c0670144..cb0b083423 100644
> --- a/blame.c
> +++ b/blame.c
> @@ -2909,9 +2909,6 @@ void setup_blame_bloom_data(struct blame_scoreboard *sb)
>  	struct blame_bloom_data *bd;
>  	struct bloom_filter_settings *bs;
>
> -	if (!sb->repo->objects->commit_graph)
> -		return;
> -
>  	bs = get_bloom_filter_settings(sb->repo);
>  	if (!bs)
>  		return;

Makes sense; get_bloom_filter_settings() (as you note) will return NULL if r->objects->commit_graph is NULL, which will cause this function to terminate early anyway.

Thanks, Taylor