git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Bug] Compat objects not added to CLAR_TEST_PROG

From
Patrick Steinhardt <ps@pks.im>
Date
Sep 9, 2025, 10:15 UTC
Message-ID
<aL_-My5lxRQiOPmh@pks.im>
In-Reply-To
<50da35ac-71f8-49dd-bcd8-83726f1954a9@innomotics.com>
On Tue, Sep 09, 2025 at 10:00:54AM +0200, Osipov, Michael (IN IT IN) wrote:
Show 35 quoted lines
> On 2025-09-09 09:45, Patrick Steinhardt wrote:
> > diff --git a/clar/sandbox.h b/clar/sandbox.h
> > index ff43159..5af36f3 100644
> > --- a/clar/sandbox.h
> > +++ b/clar/sandbox.h
> > @@ -164,7 +164,7 @@ static int build_tempdir_path(void)
> >   	if (mkdir(_clar_tempdir, 0700) != 0)
> >   		return -1;
> > -#elif defined(__sun) || defined(__TANDEM)
> > +#elif defined(__sun) || defined(__TANDEM) || defined(__HPUX)
> >   	if (mktemp(_clar_tempdir) == NULL)
> >   		return -1;
> > The `__HPUX` define is pulled out of thin air, I have no idea what
> > preprocessor macro that system sets. But something in that spirit may
> > fix that issue. If so, I'm happy to fix this upstream and then pull
> > the latest version into Git.
> 
> I can confirm that your idea works and much better than my idea:
> root@deblndw002x:/var/tmp/ports/work
> # diff -ur git-2.51.0 git-2.51.0.patched/ | grep -v "Only in"
> diff -u -ur git-2.51.0/t/unit-tests/clar/clar/sandbox.h
> git-2.51.0.patched/t/unit-tests/clar/clar/sandbox.h
> --- git-2.51.0/t/unit-tests/clar/clar/sandbox.h 2025-08-18 02:35:38 +0200
> +++ git-2.51.0.patched/t/unit-tests/clar/clar/sandbox.h 2025-09-09 09:50:07
> +0200
> @@ -128,7 +128,7 @@
> 
>         if (mkdir(_clar_path, 0700) != 0)
>                 return -1;
> -#elif defined(__sun) || defined(__TANDEM)
> +#elif defined(__sun) || defined(__TANDEM) || defined(__hpux)
>         if (mktemp(_clar_path) == NULL)
>                 return -1;
> 
> Can you make that happen upstream?

Merged upstream now via [1]. I'll send a patch to the mailing list later today to bring us to the latest version.

Patrick
[1]: https://github.com/clar-test/clar/pull/120
Previous: Osipov, Michael (IN IT IN)Next: Osipov, Michael (IN IT IN)
Message 6 of 7 in “[Bug] Compat objects not added to CLAR_TEST_PROG”
  1. Osipov, Michael (IN IT IN)Sep 5, 2025
  2. Jeff KingSep 5, 2025
  3. Osipov, Michael (IN IT IN)Sep 5, 2025
  4. Patrick SteinhardtSep 9, 2025
  5. Osipov, Michael (IN IT IN)Sep 9, 2025
  6. Patrick SteinhardtSep 9, 2025
  7. Osipov, Michael (IN IT IN)Sep 9, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.