git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] add-interactive: reject malformed numerical input

From
Patrick Steinhardt <ps@pks.im>
Date
Sep 8, 2025, 04:04 UTC
Message-ID
<aL5VxjPSqfXbnY7W@pks.im>
In-Reply-To
<aL15aTmKQOsNrF0D@Seonghyeons-Mac-Studio.local>
On Sun, Sep 07, 2025 at 09:24:09PM +0900, Seonghyeon Cho wrote:
Show 14 quoted lines
> On Tue, Sep 02, 2025 at 11:07:59AM +0200, Patrick Steinhardt wrote:
> > In general though we're not doing a good job here of error checking. We
> > don't at all verify whether `strtoul()` returned an error, for example
> > ERANGE. So if a user passes an integer that exceeds whatever we can
> > store in an `unsigned long` we'll silently proceed with a bogus result,
> > won't we?
> > 
> > Ideally, we'd use a saner interface to parse these integers, like for
> > example our own `git_parse_ulong()`. But unfortunately, that interface
> > does not handle the case where we only want to parse a substring in a
> > longer string. Too bad.
> 
> Good point. Would you prefer I introduce new parse method here, or
> should this be handled in separate patch?

I don't think that would need to be part of your patch series. But we should have proper error checking for `strtoul()` if we're already improving this code.

Patrick
Previous: Seonghyeon ChoNext: Seonghyeon Cho
Message 4 of 5 in “add-interactive: reject malformed numerical input”
  1. add-interactive: reject malformed numerical inputSeonghyeon Cho (조성현) via GitGitGadget, Aug 30, 2025
  2. Patrick SteinhardtSep 2, 2025
  3. Seonghyeon ChoSep 7, 2025
  4. Patrick SteinhardtSep 8, 2025
  5. Seonghyeon ChoSep 8, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.