Re: [PATCH v2 0/9] midx: stop duplicating info redundant with their sources

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 7, 2025, 22:27 UTC
Message-ID: <aJUoPJrVfGS5l9L1@nand.local>
In-Reply-To: <20250807-b4-pks-midx-deduplicate-source-info-v2-0-bcffb8fc119c@pks.im>

On Thu, Aug 07, 2025 at 10:09:50AM +0200, Patrick Steinhardt wrote:

Show 11 quoted lines

> ---
> Patrick Steinhardt (9):
>       odb: store locality in object database sources
>       odb: allow `odb_find_source()` to fail
>       odb: return newly created in-memory sources
>       odb: simplify calling `link_alt_odb_entry()`
>       midx: drop redundant `struct repository` parameter
>       midx: load multi-pack indices via their source
>       midx: write multi-pack indices via their source
>       midx: stop duplicating info redundant with its owning source
>       midx: compute paths via their source

I read through these patches, and they look pretty good to me. I left a few minor comments in the first half of the series, but nothing show-stopping there.

I would, however, like to hear from Stolee on the --object-dir stuff, since I am not sure if the implementation here has any unintended consequences. That feature is (as yet) mysterious to me.

Thanks, Taylor