Re: [PATCH 4/5] git-gui: honor TCLTK_PATH in git-gui--askpass

From: Patrick Steinhardt <ps@pks.im>
Date: Jul 31, 2025, 10:42 UTC
Message-ID: <aItIkhAPMuq6tlNS@pks.im>
In-Reply-To: <cb63b63b-4a74-4649-bebb-002d1e6e66f7@kdbg.org>

On Wed, Jul 30, 2025 at 09:02:50PM +0200, Johannes Sixt wrote:

Show 43 quoted lines

> Am 30.07.25 um 18:40 schrieb Carlo Marcelo Arenas Belón:
> > diff --git a/meson.build b/meson.build
> > index 1cedc82..320ba09 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -38,14 +38,6 @@ version_file = custom_target(
> >    build_always_stale: true,
> >  )
> >  
> > -configure_file(
> > -  input: 'git-gui--askpass',
> > -  output: 'git-gui--askpass',
> > -  copy: true,
> > -  install: true,
> > -  install_dir: get_option('libexecdir') / 'git-core',
> > -)
> > -
> >  gitgui_main = 'git-gui'
> >  gitgui_main_install_dir = get_option('libexecdir') / 'git-core'
> >  
> > @@ -61,6 +53,20 @@ if target_machine.system() == 'windows'
> >    )
> >  endif
> >  
> > +custom_target(
> > +  output: 'git-gui--askpass',
> > +  input: 'git-gui--askpass.sh',
> > +  command: [
> > +    shell,
> > +    meson.current_source_dir() / 'generate-script.sh',
> > +    '@OUTPUT@',
> > +    '@INPUT@',
> > +    meson.current_build_dir() / 'GIT-GUI-BUILD-OPTIONS',
> > +  ],
> > +  install: true,
> > +  install_dir: get_option('libexecdir') / 'git-core',
> > +)
> > +
> >  custom_target(
> >    input: 'git-gui.sh',
> >    output: gitgui_main,
> 
> I can't comment on the meson part at all.

The Meson part looks reasonable to me.

Patrick