git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6] meson: work around broken system PCRE2 dependency in macOS

From
Patrick Steinhardt <ps@pks.im>
Date
Jul 24, 2025, 05:28 UTC
Message-ID
<aIHENdrLu7vtShov@pks.im>
In-Reply-To
<xmqq8qkelfgo.fsf@gitster.g>
On Wed, Jul 23, 2025 at 03:17:27PM -0700, Junio C Hamano wrote:
Show 30 quoted lines
> Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
> 
> > macOS provides a PCRE2 library in base that is not usable and not
> > configured properly, as it installs a pkgconf module that
> > points to a non-existent pcre2.h header in /usr/local/include.
> >
> > Detect that case and if the feature is enabled, try to fallback
> > to a wrapped subproject through an anonymous dependency, aborting
> > with an error if that is not possible.
> >
> > Change the feature to "auto" and print a warning and disable it
> > if a broken dependency was detected, but to keep consistency
> > with the cmake build system used on Windows, add a special rule
> > to re-enable the pcre2 feature by default there.
> >
> > Helped-by: Eric Sunshine <sunshine@sunshineco.com>
> > Suggested-by: Eli Schwartz <eschwartz@gentoo.org>
> > Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> > ---
> >  meson.build       | 28 +++++++++++++++++++++++++++-
> >  meson_options.txt |  2 +-
> >  2 files changed, 28 insertions(+), 2 deletions(-)
> 
> The thread went silent after this iteration.
> 
> I _think_ it incorporates all the good suggestions offered during
> the discussion on the previous iterations, but is everybody happy
> with this version?  If so, let me mark the topic for 'next'.
> 
> Thanks, all.
I think this version is fine. Thanks!
Patrick
Previous: Junio C Hamano
Message 28 of 28 in “meson: disable PCRE2 dependency by default”
  1. meson: disable PCRE2 dependency by defaultCarlo Marcelo Arenas Belón, Jul 12, 2025
  2. brian m. carlsonJul 12, 2025
  3. Carlo ArenasJul 14, 2025
  4. Junio C HamanoJul 14, 2025
  5. Carlo Marcelo Arenas BelónJul 14, 2025
  6. Junio C HamanoJul 14, 2025
  7. meson: disable PCRE2 dependency by default in macOSCarlo Marcelo Arenas Belón, Jul 13, 2025
  8. Junio C HamanoJul 13, 2025
  9. meson: disable PCRE2 dependency by default in macOSCarlo Marcelo Arenas Belón, Jul 13, 2025
  10. Eli SchwartzJul 15, 2025
  11. Patrick SteinhardtJul 15, 2025
  12. Carlo ArenasJul 15, 2025
  13. Patrick SteinhardtJul 15, 2025
  14. Carlo ArenasJul 15, 2025
  15. Eli SchwartzJul 15, 2025
  16. Carlo ArenasJul 15, 2025
  17. Eli SchwartzJul 15, 2025
  18. meson: woraround broken system PCRE2 dependency in macOSCarlo Marcelo Arenas Belón, Jul 15, 2025
  19. Junio C HamanoJul 15, 2025
  20. Eric SunshineJul 15, 2025
  21. meson: work around broken system PCRE2 dependency in macOSCarlo Marcelo Arenas Belón, Jul 16, 2025
  22. Junio C HamanoJul 16, 2025
  23. Junio C HamanoJul 16, 2025
  24. Eli SchwartzJul 16, 2025
  25. Carlo ArenasJul 16, 2025
  26. meson: work around broken system PCRE2 dependency in macOSCarlo Marcelo Arenas Belón, Jul 18, 2025
  27. Junio C HamanoJul 23, 2025
  28. Patrick SteinhardtJul 24, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.