Re: [PATCH 5/6] parse-options: add precision handling for OPTION_BITOP

From: Patrick Steinhardt <ps@pks.im>
Date: Jul 1, 2025, 10:55 UTC
Message-ID: <aGO-kbdAgMMef-A5@pks.im>
In-Reply-To: <7b970f48-05a8-40c6-8e5b-95ce830705c0@web.de>

On Sun, Jun 29, 2025 at 01:51:19PM +0200, René Scharfe wrote:

Show 7 quoted lines

> Similar to 09705696f7 (parse-options: introduce precision handling for
> `OPTION_INTEGER`, 2025-04-17) support value variables of different sizes
> for OPTION_BITOP.  Do that by requiring their "precision" to be set,
> casting their "value" pointer accordingly and checking whether the value
> fits.
> 
> Checking "defval" has the side-effect of also requiring PARSE_OPT_NOARG.

Hm, requiring PARSE_OPT_NOARG for what? I cannot see it being touched in this patch at all, so I'm a but puzzled.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.