Re: [PATCH v4 01/17] object-store: rename `raw_object_store` to `object_database`

From: Patrick Steinhardt <ps@pks.im>
Date: Jun 4, 2025, 11:52 UTC
Message-ID: <aEAzZLgPWCGwdpiE@pks.im>
In-Reply-To: <87a56n3myb.fsf@iotcl.com>

On Wed, Jun 04, 2025 at 10:55:40AM +0200, Toon Claes wrote:

Show 17 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/object-store.h b/object-store.h
> > index c5890085352..a3be27d1171 100644
> > --- a/object-store.h
> > +++ b/object-store.h
> > @@ -87,7 +87,12 @@ struct packed_git;
> >  struct multi_pack_index;
> >  struct cached_object_entry;
> >  
> > -struct raw_object_store {
> > +/*
> > + * The object database encapsulates access to objects in a repository. It
> > + * manages one or more backends that store the actual objects which are
> > + * configured via alternates.
> 
> This still uses /old/ terminology. I think the "backend" should be
> called "source", and we can keep the "alternates"?

The term "source" doesn't yet exist in this commit. The next commit touches the comment, but _that_ commit still uses the old "alternate" term to talk about the sources. It's correct to say that those are configured via alternates, but the alternates do configure sources in the ODB indeed.

Patrick