Re: [PATCH] t0200: replace 'test -d' with 'test_path_is_dir' and 'test -f' with 'test_path_is_file'

From: Patrick Steinhardt <ps@pks.im>
Date: Jun 3, 2025, 06:16 UTC
Message-ID: <aD6TJLuuaZmiFUvZ@pks.im>
In-Reply-To: <20250603053137.66249-1-derick.william.moraes@gmail.com>

On Tue, Jun 03, 2025 at 02:20:28AM -0300, Derick W. de M. Frias wrote:

> From: DerickWMFrias <derick.william.moraes@gmail.com>

There is a mismatch between your name here (which would be applied as the patch author) and the Signed-off-by. These two should match.

> 'test_path_is_file' and 'test_path_is_dir' are modern path checking
> methods in Git's development.

We typically want to provide enough context in commit messages to state _why_ the replacement is better. Them being more "modern" isn't yet a sufficiently good reason. So it would be great if we explicitly mention what the replacements bring to the table in a sentence or two.

> This patch replaces old 'test -d' and 'test -f' methods with them.

We use imperative style for commit messages, as if instructing the code to change. So instead of saying "This patch replaces", we'd say "Replace `test -d` and `test -f` ...".

The patch itself looks obviously good to me, thanks!

Patrick