git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] replay: replace the_repository with repo parameter passed to cmd_replay()

From
Patrick Steinhardt <ps@pks.im>
Date
May 15, 2025, 13:24 UTC
Message-ID
<aCXq_ck96l0AjScp@pks.im>
In-Reply-To
<pull.1921.git.1747254806067.gitgitgadget@gmail.com>
On Wed, May 14, 2025 at 08:33:25PM +0000, Elijah Newren via GitGitGadget wrote:
Show 19 quoted lines
> From: Elijah Newren <newren@gmail.com>
> 
> Replace the_repository everywhere with repo, feed repo from cmd_replay()
> to all the other functions in the file that need it, and remove the
> UNUSED annotation on repo.
> 
> Signed-off-by: Elijah Newren <newren@gmail.com>
> ---
>     replay: replace the_repository with repo parameter passed to cmd_replay
>     
>     The point of this patch is not to remove USE_THE_REPOSITORY_VARIABLE; I
>     can't yet because DEFAULT_ABBREV and get_commit_output_encoding() both
>     require it and have no current alternatives. However, I still think it's
>     worthwhile to stop using the_repository everywhere while ignoring the
>     repo parameter explicitly passed in. That looks kinda ugly, and since
>     I'm poking around in replay right now, I don't want to push
>     the_repository in even more places when we have the appropriate value
>     available -- especially since that might make my local work conflict
>     should someone else come along and try to clean this up.

Makes sense. Especially the first one is something I have encountered as a frequent blocker for removing `USE_THE_REPOSITORY_VARIABLE`. I guess it would be nice to tackle it sooner rather than later.

Cc'd Ayush, as he will be working on the global state reduction project as part of GSoC.

Patrick
Previous: Junio C Hamano
Message 3 of 3 in “replay: replace the_repository with repo parameter passed to cmd_replay()”
  1. replay: replace the_repository with repo parameter passed to cmd_replay()Elijah Newren via GitGitGadget, May 14, 2025
  2. Junio C HamanoMay 14, 2025
  3. Patrick SteinhardtMay 15, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.