Re: [PATCH 1/2] gitk: align the commit summary format to the documentation
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Aug 27, 2016, 07:21 UTC
- Message-ID
- <a9731f60-5c30-0bc6-f73a-f7ffb7bd4231@kdbg.org>
- In-Reply-To
- <xmqqoa4fgzhv.fsf@gitster.mtv.corp.google.com>
Am 26.08.2016 um 20:24 schrieb Junio C Hamano:
Show 7 quoted lines
> Beat Bolli <dev+git@drbeat.li> writes:
>> In 175d38c ("SubmittingPatches: document how to reference previous commits",
>> 2016-07-28) the format for referring to older commits was specified.
>
> is easier to read when pasted into a sentence than what the recent
> update 175d38ca ("SubmittingPatches: document how to reference
> previous commits", 2016-07-28) suggests to do, i.e.While it may be easier to read due to the extra mark-up, the resulting text where such a quotation appears does not flow well, IMO. A commit message text that references another commit reads more fluently without the quotes around the summary line because the quoted text is not so much a quotation that must be marked, but a parenthetical statement.
I absolutely welcome the proposed change to gitk, because I always edit out the double-quotes.
-- Hannes