Re: [PATCH] gitweb: Handle actions with no project in evaluate_path_info

From: Devin Doucette <devin@doucette.cc>
Date: Jan 2, 2009, 02:21 UTC
Message-ID: <a899d7ef0901011821x166f173dx47bdb41326391696@mail.gmail.com>
In-Reply-To: <cb7bb73a0901011646n6a1368caq797a5f2849daec77@mail.gmail.com>

On Thu, Jan 1, 2009 at 5:46 PM, Giuseppe Bilotta <giuseppe.bilotta@gmail.com> wrote:

> Actually, the early bailout was sort of intentional. The problem is
> the ambiguity: does git.example.com/opml refer to the opml project, or
> does it refer to the opml action?

Good point. Though my patch does not break any existing functionality, it does not fix the case where a project matches the action.

Show 6 quoted lines

> HOWEVER, href() *does* create the opml action as git.example.com/opml,
> so gitweb is currently broken in the sense that ti doesn't correctly
> parse its own pathinfo output. So the question is: shall we go with
> this patch, preventing pathinfo from working for projects named like a
> no-project gitweb action, or should we fix href() to not generate
> pathinfo unless project is defined?

A variation of the latter approach is to modify href() to use pathinfo if there is a project or there is no project matching the name of the action. The only downside to this approach is that a URI that refers to an action when first generated could resolve to a project in the future, if a project of the same name were added.

-- Devin Doucette