RE: [External Mail]Re: [PATCH 3/3] parse_object(): check commit-graph when skip_hash set

From: 程洋 <chengyang@xiaomi.com>
Date: Sep 8, 2022, 10:39 UTC
Message-ID: <a87e9eaccf7849fc9eeb10ce7d373db0@xiaomi.com>
In-Reply-To: <xmqqv8pzt20d.fsf@gitster.g>

Show 6 quoted lines

> If the caller told us that they don't care about us checking the
> object hash, then we're free to implement any optimizations that get
> us the parsed value more quickly. An obvious one is to check the
> commit graph before loading an object from disk. And in fact, both of
> the callers who pass in this flag are already doing so before they call
> parse_object()!

> So we can simplify those callers, as well as any possible future ones,
> by moving the logic into parse_object().

I need to mention that there is serious issue with commit-graph together with partial-clone https://lore.kernel.org/git/20220709005227.82423-1-hanxin.hx@bytedance.com/

So actually I told my users to disable commit-graph manually #/******本邮件及其附件含有小米公司的保密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本邮件！ This e-mail and its attachments contain confidential information from XIAOMI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!******/#