Re: [PATCH 1/2] checkout: add tests for -b and --track

From: René Scharfe <l.s.r@web.de>
Date: May 28, 2020, 13:53 UTC
Message-ID: <a879b067-978c-aa9f-fb51-a9e717363544@web.de>
In-Reply-To: <20200527064056.GA4005121@coredump.intra.peff.net>

Am 27.05.20 um 08:40 schrieb Jeff King:

Show 16 quoted lines

> On Sun, May 24, 2020 at 09:22:51AM +0200, René Scharfe wrote:
>
>> Test git checkout -b with and without --track and demonstrate unexpected
>> error messages when it's given an extra (i.e. unsupported) path
>> argument.  In both cases it reports:
>>
>>    $ git checkout -b foo origin/master bar
>>    fatal: 'bar' is not a commit and a branch 'foo' cannot be created from it
>>
>> The problem is that the start point we gave for the new branch is
>> "origin/master" and "bar" is just some extra argument -- it could even
>> be a valid commit, which would make the message even more confusing.  We
>> have more fitting error messages in git commit, but get confused; use
>> the text of the rights ones in the tests.
>
> Did you mean "more fitting error message in git checkout"?

Dang, yes, a typo -- it's all about checkout.

René