Re: gitattributes export-subst and software versioning
- From
René Scharfe <l.s.r@web.de>
- Date
- Feb 14, 2021, 10:04 UTC
- Message-ID
- <a8171389-4296-8edb-5294-6a77dc1e5fa2@web.de>
- In-Reply-To
- <xmqqpn190y8a.fsf@gitster.c.googlers.com>
Am 09.02.21 um 21:42 schrieb Junio C Hamano:
Show 16 quoted lines
> Eli Schwartz <eschwartz@archlinux.org> writes: > >>> And replacing the flags with a commit slab doesn't seem to be enough, >>> either -- I get good results lots of commits, but for some git log with >>> the new placeholder would just show some nonsensical output, as it >>> seems to get the depth calculation wrong for them somehow. >> >> You mean git describe <commit> produces wrong results for those? > > Running "describe" as an external command, like the patch you are > responding to does, would not produce any wrong result, but Réne's > point is that it would be very involved to turn "describe" into a > function that can be called as if it is a library function without > disrupting the operation of "log" that is running in the same > address space, and the change he tried had some weird bugs to get > the computation wrong.
Yes, indeed. Let's go with the forking version for now -- it may be slow, but it's fast enough, and it's better than nothing.
René