git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pack-write.c: remove unused `mtimes_name` parameter

From
Derrick Stolee <derrickstolee@github.com>
Date
Jun 15, 2022, 13:30 UTC
Message-ID
<a7c81b77-651d-3374-6db8-f46ad01a8319@github.com>
In-Reply-To
<f5bf68702d55b601ebd13bc4a6f1a34dc35abae5.1655253465.git.me@ttaylorr.com>
On 6/14/22 8:37 PM, Taylor Blau wrote:
Show 7 quoted lines
> `write_mtimes_file()` takes an optional parameter `mtimes_name`, which
> specifies where to write the mtimes file. If it is NULL, a location is
> generated with `odb_mkstemp()`.
> 
> This imitates the pattern in `write_idx_file()`, and `write_rev_file()`,
> both of which have callers from the `index-pack` builtin which specify
> an exact location instead of generating one.

I have a nearly-identical patch [1], but I'm happy to take Taylor's instead. I'll plan on dropping that patch from my v2.

[1] https://lore.kernel.org/git/b67e110bf60e820874de94c64ee8c32d69413877.1655242070.git.gitgitgadget@gmail.com/

Thanks, -Stolee

Previous: Taylor BlauNext: Taylor Blau
Message 2 of 3 in “pack-write.c: remove unused `mtimes_name` parameter”
  1. pack-write.c: remove unused `mtimes_name` parameterTaylor Blau, Jun 15, 2022
  2. Derrick StoleeJun 15, 2022
  3. Taylor BlauJun 15, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.