Re: [msysGit] [PATCH] git-gui: use themed tk widgets with Tk 8.5

From: Pat Thoyts <patthoyts@googlemail.com>
Date: Dec 20, 2009, 20:25 UTC
Message-ID: <a5b261830912201225q7d596b55qb54676922301954e@mail.gmail.com>
In-Reply-To: <7vws0ha2mt.fsf@alter.siamese.dyndns.org>

2009/12/20 Junio C Hamano <gitster@pobox.com>:

>
> On X, does the "default: thin borders, kind of windows98ish" look very
> different from the non-themed classic Tk style?
>

Here is a big set of screenshots then:

Unmodified or with Tk 8.4: original windows: http://www.patthoyts.tk/screenshots/git-gui-old.png original unix: http://www.patthoyts.tk/screenshots/git-gui-x11.png

With Tk 8.5 and using themed widgets:
unix default: http://www.patthoyts.tk/screenshots/git-gui-default.png
unix alt:        http://www.patthoyts.tk/screenshots/git-gui-alt.png
unix classic: http://www.patthoyts.tk/screenshots/git-gui-classic.png
unix clam:     http://www.patthoyts.tk/screenshots/git-gui-clam.png
unix tileqt:    http://www.patthoyts.tk/screenshots/git-gui-tileqt.png
 (experimental)

windows7:     http://www.patthoyts.tk/screenshots/git-gui-win32.png

Show 14 quoted lines

> What I am trying to get at is to gain enough information so that I can
> suggest a rewrite of these two lines (quoted at the beginning by Dscho)
> like this:
>
>   Ttk defaults to the native look as much as possible on Windows and
>   MacOSX; the default on X is the _________ look.
>
>   The user may choose a theme by:
>
>   - on Windows, doing ________;
>   - on MacOSX, doing _________;
>   - on X, selecting a theme using the TkTheme XRDB resource class;
>
> which I think would be much easier to read.

You write better than I do. The theme used globally by themed Tk can
be selected on at least Ubuntu's GNOME desktop by adding the following
line into ~/.Xresources:
  *TkTheme: clam
It is also possible to add a Theme menu or selection combobox onto the
options dialog and record a theme selection along with the other
git-gui saved options. Then a user could use 'git config gui.theme
clam'. The set of available themes can be extended with packages and
is somewhat platform dependent (ie: xpnative can only be present on
Windows XP and above).

Pat Thoyts.