Re: [PATCH] push: don't fetch commit object when checking existence
- From
Tom Hughes <tom@compton.nu>
- Date
- May 22, 2024, 20:18 UTC
- Message-ID
- <a546ca21-22ab-4a0d-9afa-e5c91830a5c2@compton.nu>
- In-Reply-To
- <xmqq8r014pyn.fsf@gitster.g>
On 22/05/2024 20:16, Junio C Hamano wrote:
Show 15 quoted lines
> Tom Hughes <tom@compton.nu> writes: > >> If we're checking to see whether to tell the user to do a fetch >> before pushing there's no need for us to actually fetch the object >> from the remote if the clone is partial. >> >> Because the promisor doesn't do negotiation actually trying to do >> the fetch of the new head can be very expensive as it will try and >> include history that we already have and it just results in rejecting >> the push with a different message, and in behavior that is different >> to a clone that is not partial. > > Interesting. Is this something that is easily testable, perhaps by > preparing a partial clone and try to push from there and checking > the non-existence of the object after seeing that push failed?
Sure. I think I've managed to figure out a test and have sent a second version of the patch with it added.
Tom
-- Tom Hughes (tom@compton.nu) http://compton.nu/