Re: should git maintenance prefetch be taught to honor remote.fetch refspec?
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Apr 2, 2021, 21:07 UTC
- Message-ID
- <a4cf3e48-aed5-ba1f-298d-1f2cc2359be2@gmail.com>
- In-Reply-To
- <41dc2961-7ba5-a882-3416-45631e2cbb33@gmail.com>
On 4/2/2021 4:43 PM, Derrick Stolee wrote:
Show 19 quoted lines
> On 4/2/2021 2:27 PM, Tom Saeger wrote: >> generally isn't it still changing the right-hand side of refspec? >> >> replacing ":refs/" with ":refs/prefetch/" > > Right, this substring replacement might be easiest to achieve. The > 'struct refspec' doesn't make it incredibly easy. Perhaps skipping > the refspec parsing and just doing that substring swap directly from > the config value might be the best approach. > >> This would still work for refspecs with negative patterns right? > > One of the issues is that negative patterns have no ":refs/" > substring. > > The other issue is that exact matches (no "*") have an exact > string in the destination, too, so replacing the _entire_ > destination with "refs/prefetch/<remote>/*" breaks the refspec. > I think the substring approach will still work here.
I updated my branch with the substring approach, which is probably the better solution. Please give it a try. I don't expect that change to help the FreeBSD build, but we will see.
> [1] https://github.com/gitgitgadget/git/pull/924 > [2] https://github.com/gitgitgadget/git/pull/924/checks?check_run_id=2256079534
Thanks, -Stolee