git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 4/4] refs: read FETCH_HEAD and MERGE_HEAD generically

From
Han-Wen Nienhuys via GitGitGadget <gitgitgadget@gmail.com>
Date
Aug 19, 2020, 14:27 UTC
Message-ID
<a3e903e4c0b29a3c37a43b0e76060aa3bb250cfa.1597847278.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.705.v2.git.1597847278.gitgitgadget@gmail.com>
From: Han-Wen Nienhuys <hanwen@google.com>

The FETCH_HEAD and MERGE_HEAD refs must be stored in a file, regardless of the type of ref backend. This is because they can hold more than just a single ref.

To accomodate them for alternate ref backends, read them from a file generically in refs_read_raw_ref()

Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
---
 refs.c | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/refs.c b/refs.c
index cf91711968..3ee3afaf41 100644
--- a/refs.c
+++ b/refs.c
@@ -1527,11 +1527,37 @@ int for_each_rawref(each_ref_fn fn, void *cb_data)
 	return refs_for_each_rawref(get_main_ref_store(the_repository), fn, cb_data);
 }
 
+static int refs_read_special_head(struct ref_store *ref_store,
+				  const char *refname, struct object_id *oid,
+				  struct strbuf *referent, unsigned int *type)
+{
+	struct strbuf full_path = STRBUF_INIT;
+	struct strbuf content = STRBUF_INIT;
+	int result = -1;
+	strbuf_addf(&full_path, "%s/%s", ref_store->gitdir, refname);
+
+	if (strbuf_read_file(&content, full_path.buf, 0) < 0)
+		goto done;
+
+	result = parse_loose_ref_contents(content.buf, oid, referent, type);
+
+done:
+	strbuf_release(&full_path);
+	strbuf_release(&content);
+	return result;
+}
+
 int refs_read_raw_ref(struct ref_store *ref_store,
 		      const char *refname, struct object_id *oid,
 		      struct strbuf *referent, unsigned int *type)
 {
-	return ref_store->be->read_raw_ref(ref_store, refname, oid, referent, type);
+	if (!strcmp(refname, "FETCH_HEAD") || !strcmp(refname, "MERGE_HEAD")) {
+		return refs_read_special_head(ref_store, refname, oid, referent,
+					      type);
+	}
+
+	return ref_store->be->read_raw_ref(ref_store, refname, oid, referent,
+					   type);
 }
 
 /* This function needs to return a meaningful errno on failure */
-- 
gitgitgadget
Previous: Han-Wen Nienhuys via GitGitGadgetNext: Han-Wen Nienhuys via GitGitGadget
Message 10 of 12 in “Handle FETCH_HEAD generically”
  1. 0/4 Handle FETCH_HEAD genericallyHan-Wen Nienhuys via GitGitGadget, Aug 17, 2020
  2. 1/4 Split off reading loose ref data in separate functionHan-Wen Nienhuys via GitGitGadget, Aug 17, 2020
  3. 2/4 refs: fix comment about submodule ref_storesHan-Wen Nienhuys via GitGitGadget, Aug 17, 2020
  4. 3/4 refs: move gitdir into base ref_storeHan-Wen Nienhuys via GitGitGadget, Aug 17, 2020
  5. 4/4 refs: read FETCH_HEAD genericallyHan-Wen Nienhuys via GitGitGadget, Aug 17, 2020
  6. Junio C HamanoAug 17, 2020
  7. 0/4 Handle FETCH_HEAD and MERGE_HEAD genericallyHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  8. 2/4 refs: fix comment about submodule ref_storesHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  9. 3/4 refs: move gitdir into base ref_storeHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  10. 4/4 refs: read FETCH_HEAD and MERGE_HEAD genericallyHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  11. 1/4 refs: split off reading loose ref data in separate functionHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  12. Junio C HamanoAug 19, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.