Re: [GSoC][PATCH 1/4] rebase: duplicate git-rebase--interactive.sh to git-rebase--preserve-merges.sh

From: Alban Gruin <alban.gruin@gmail.com>
Date: May 22, 2018, 19:15 UTC
Message-ID: <a3d0d6f6-c6c8-ad70-4e1a-7804dbfa1b35@gmail.com>
In-Reply-To: <CAGZ79kaTPu=z_6oJk__meuyhUt-pU_LtOJ90rPTQcC=YvhnOnw@mail.gmail.com>

Hi Stefan,

Le 22/05/2018 à 20:26, Stefan Beller a écrit :

Show 17 quoted lines

> On Tue, May 22, 2018 at 6:31 AM, Alban Gruin <alban.gruin@gmail.com> wrote:
>> This duplicates git-rebase--interactive.sh to
>> git-rebase--preserve-merges.sh. This is done to split -p from -i. No
>> modifications are made to this file here, but any code that is not used by -p
>> will be stripped in the next commit.
>>
>> Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
> 
> So how would I best review this?
> 
> I applied the patches locally[1], and ran git-ls-tree on this commit
> hoping to find the same blob id for git-rebase--interactive.sh as for
> git-rebase--preserve-merges.sh; however I did not.
> 
> So I diffed them and had the diff below[2], which looks like that has parts
> of Johannes recent series?
>

Thanks for the heads-up.

I started to work on that patch set on the master branch of git.git, and I forgot to update git-rebase--preserve-merges.sh after rebasing on Johannes’ branch.

So I’ll reroll the patch as soon as possible.

> Thanks,
> Stefan
>