Re: [PATCH v3 2/2] hook: make ungroup opt-out instead of opt-in

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Jan 18, 2026, 08:44 UTC
Message-ID: <a2408c8c-db6e-4632-8fd8-7ac888bd3fa2@app.fastmail.com>
In-Reply-To: <20260114185731.2381550-3-adrian.ratiu@collabora.com>

On Wed, Jan 14, 2026, at 19:57, Adrian Ratiu wrote:

Show 16 quoted lines

> In 857f047e40 (hook: allow overriding the ungroup option, 2025-12-26),
> I accidentally made the ungroup option opt-in instead of opt-out and
> despite my best efforts to set it for all API users, I missed a case
> which requires it to be set: the pre-push hook which regressed.
>
> The only thing I needed in that commit was a way to change the default,
> to convert the remaining receive-pack hooks which require ungroup == 0
> for sideband output, so it doesn't matter if it's on or off by default.
>
> Bring back the original behavior by setting it for all hooks in the
> struct run_hooks_opt initializer, which nicely allows changing the
> default value only where needed, in receive-pack.c.
>
> While at it add a few hook tests which exercise receive-pack sideband
> output since they are the only ungroup=0 exceptions and there are no
> other tests exercising this functionality.

This description looks okay given that the regression was never released. Only those who go out of their way build on top of `master` (for some reason) could have observed it. However if this was a bug in some release then the description is very technical and play-by-play. As a Git user reading this isolation, I see nothing that links these concrete code discussions back to something that might have been weird in my hook scripts.

This would be especially relevant given that this bug is so weird. It’s not a crash with some error text that can be googled; everything works (eventually) the same as before, only that *if* you read from standard input you’ll have to wait a minute or so for something to time out and unstuck the whole process.

Again. I think this is okay since it was never a bug in any release.

Show 7 quoted lines

>
> Fixes: 857f047e40f7 ("hook: allow overriding the ungroup option")
> Reported-by: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
> Suggested-by: Jeff King <peff@peff.net>
> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
> ---
>[snip]