git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 4/4] t2016: add a NEEDSWORK about the PERL prerequisite

From
Denton Liu <liu.denton@gmail.com>
Date
Oct 7, 2020, 07:56 UTC
Message-ID
<a20544f18a1dfbeea44faad8538d2de3baf3d62b.1602057332.git.liu.denton@gmail.com>
In-Reply-To
<cover.1602057332.git.liu.denton@gmail.com>

Since the builtin add-p is used when $GIT_TEST_ADD_I_USE_BUILTIN is given, we should replace the PERL prerequisite with an ADD_I prerequisite which first checks if $GIT_TEST_ADD_I_USE_BUILTIN is defined before checking PERL.[0] Mark this in a NEEDSWORK so that it can be addressed at a later time.

[0]: https://lore.kernel.org/git/xmqqsgat7ttf.fsf@gitster.c.googlers.com/
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 t/t2016-checkout-patch.sh | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/t/t2016-checkout-patch.sh b/t/t2016-checkout-patch.sh
index 999620e507..d91a329eb3 100755
--- a/t/t2016-checkout-patch.sh
+++ b/t/t2016-checkout-patch.sh
@@ -18,6 +18,10 @@ test_expect_success PERL 'setup' '
 
 # note: bar sorts before dir/foo, so the first 'n' is always to skip 'bar'
 
+# NEEDSWORK: Since the builtin add-p is used when $GIT_TEST_ADD_I_USE_BUILTIN
+# is given, we should replace the PERL prerequisite with an ADD_I prerequisite
+# which first checks if $GIT_TEST_ADD_I_USE_BUILTIN is defined before checking
+# PERL.
 test_expect_success PERL 'saying "n" does nothing' '
 	set_and_save_state dir/foo work head &&
 	test_write_lines n n | git checkout -p &&

-- 
2.28.0.942.g77c4c6094c
Previous: Denton LiuNext: Denton Liu
Message 8 of 9 in “checkout/restore: fix `git checkout -p HEAD...` bug”
  1. 0/2 checkout/restore: fix `git checkout -p HEAD...` bugDenton Liu, Oct 4, 2020
  2. 1/2 builtin/checkout: fix `git checkout -p HEAD...` bugDenton Liu, Oct 4, 2020
  3. Junio C HamanoOct 4, 2020
  4. 2/2 Doc: document "A...B" form for <tree-ish> in checkout and switchDenton Liu, Oct 4, 2020
  5. 0/4 checkout/restore: fix `git checkout -p HEAD...` bugDenton Liu, Oct 7, 2020
  6. 1/4 builtin/checkout: fix `git checkout -p HEAD...` bugDenton Liu, Oct 7, 2020
  7. 2/4 Doc: document "A...B" form for <tree-ish> in checkout and switchDenton Liu, Oct 7, 2020
  8. 4/4 t2016: add a NEEDSWORK about the PERL prerequisiteDenton Liu, Oct 7, 2020
  9. 3/4 add-patch: add NEEDSWORK about comparing commitsDenton Liu, Oct 7, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.