Re: [PATCH] remote: pass NULL to read_ref_full() because object ID is not needed

From: Derrick Stolee <stolee@gmail.com>
Date: Dec 11, 2019, 18:57 UTC
Message-ID: <a1bfb55c-21dd-12e6-186b-44c1873d1c52@gmail.com>
In-Reply-To: <24fc1649-d80c-cc4b-8268-a7833812d39c@web.de>

On 12/11/2019 1:46 PM, René Scharfe wrote:

> read_ref_full() wraps refs_read_ref_full(), which in turn wraps
> refs_resolve_ref_unsafe(), which handles a NULL oid pointer of callers
> not interested in the resolved object ID.  Make use of that feature to
> document that mv() is such a caller.

Double-checking the code shows this in refs_resolve_ref_unsafe():

        if (!oid)
                oid = &unused_oid;

where unused_oid is a local struct. Unfortunate that the correct code change doesn't get any performance benefit for sending this message of "I don't need this value".

LGTM.

-Stolee