Re: .gitignore, .gitattributes, .gitmodules, .gitprecious?,.gitacls? etc.
- From
- Dmitry Kakurin <dmitry.kakurin@gmail.com>
- Date
- Sep 5, 2007, 08:06 UTC
- Message-ID
- <a1bbc6950709050106j137215obd7272b2a77c3b13@mail.gmail.com>
- In-Reply-To
- <20070904202326.GC3786@efreet.light.src>
On 9/4/07, Jan Hudec <bulb@ucw.cz> wrote:
Show 24 quoted lines
> On Tue, Aug 28, 2007 at 09:49:47 +0100, Johannes Schindelin wrote: > > On Mon, 27 Aug 2007, Dmitry Kakurin wrote: > > > > > Here is the problem: we need to apply crlf attributes to a file. We > > > could have .gitattributes both in the index and in the worktree. > > > Which one do we use? > > > In general .gitattributes file could be (U)nchanged, (C)hanged, (NP) > > > NotPresent in each place. > > > > I do not see these cases. You can have these cases, basically: > > > > - .gitattributes in worktree (then it does not matter what else we have), > > - .gitattributes not in the worktree, but in the index (then that is taken) > > > > In the latter case, there could be conflicts _in_ .gitattributes, in which > > case those .gitattributes are ignored. > > > > I do not see any problem with that. > > I do. > > IMNSHO it should be the other way around: > .gitattributes in index, than index version is used. > .gitattributes not in index, but in worktree, than that tree version is used.
Consider scenario when my commit #1 has .gitattributes:
a.txt -nocrlf
and file a.txt
You pull it.
Now I make some changes to a.txt and realize that a.txt *is* a text
file now. I remove the entry from .gitattributes and notice that it
becomes empty. So I just remove .gitattributes file all together. It
becomes commit#2.
Now you pull it again. There *is* .gitattributes in local directory,
but index does not have it (because I've removed it on purpose). What
should happen?
I assert that since index does not have .gitattributes the one from
local directory should not be used.Think about dedicated build machine scenario: I have a machine that always does sync + build. After every sync the local directory should always be identical to what-was-committed. With every commit 3 things could happen: .gitattributes could appear, disappear or change. In every case "build machine" must produce the exact copy of what-was-checked-in. The only way I see this happening is by using *only* index version of .gitattributes when files are moved index -> workspace.
A similar reasoning works for other direction (workplace -> index).
-- - Dmitry