Re: [PATCH 0/2] Add cmd_gud and detect libiconv path for Mac OS

From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Sep 8, 2021, 06:01 UTC
Message-ID: <a1ba4d11-222a-92a1-257d-522dc4e0d8e0@gmail.com>
In-Reply-To: <20210908051340.13332-1-colinpcurtis826@ucla.edu>

On 08/09/21 12.13, Colin Curtis wrote:

Show 13 quoted lines

> From: Colin Curtis <colinpcurtis@gmail.com>
> 
> The gud command opens the Pro Git book webpage in the default
> web browser.  The reason to add this command is due to the
> play on words when saying 'git gud', which sounds like 'get good'.
> Hence this command when invoked will open up the Pro Git
> webpage to allow the user to 'get good' at git.
> 
> We also fix a bug in the Makefile when running on Mac OS, namely
> the libiconv path when using a brew install for the library.  Previously
> the developer would have to manually change the path to the library when
> developing on Mac OS.
>

Two distinct topics in one patch series. Why don't you create separate patch series for each topic?

For `git gud`, I think there's no point on adding such easter egg, since users can simply access git-scm.com with their browser, without needing specialized command just to invoke it.

-- 
An old man doll... just what I always wanted! - Clara