Re: [PATCH] doc: note that interactive.singleKey is disabled by default

From: Dragan Simic <dsimic@manjaro.org>
Date: May 22, 2024, 20:50 UTC
Message-ID: <a04bc0c38ad287b892c7dde37d782f12@manjaro.org>
In-Reply-To: <xmqqttip379x.fsf@gitster.g>

On 2024-05-22 22:45, Junio C Hamano wrote:

Show 17 quoted lines

> Dragan Simic <dsimic@manjaro.org> writes:
> 
>>   interactive.singleKey
>>      If true, allow the user to provide one-letter input with a
>>      single key (i.e., without hitting Enter key) in interactive
>>      commands.
>>      [...]
>> 
>> Thoughts?  It would be more consistent and a bit more clear, without
>> putting too much stress on the actual default value.
> 
> "When set to true" or "when configured to true" is much better than
> "defaults to true".
> 
> I am ambivalent about "If true", though.  It still leaves it open
> for some mysterious "default" mechanism giving the value true
> without user doing anything explicitly.

Makes sense. I'll send the v2 of this patch with "when set to true" in use, possibly with another patch that addresses already existing instances of "if true", for consistency.