Re: [PATCHv2 2/2] tests for git alternate command
- From
Chris Packham <judge.packham@gmail.com>
- Date
- Mar 25, 2010, 18:51 UTC
- Message-ID
- <a038bef51003251151h5ede3ab8jc22a61cc35706240@mail.gmail.com>
- In-Reply-To
- <4BAB12E1.8070602@viscovery.net>
On Thu, Mar 25, 2010 at 12:38 AM, Johannes Sixt <j.sixt@viscovery.net> wrote:
Show 6 quoted lines
> Am 3/25/2010 7:07, schrieb Chris Packham: >> Signed-off-by: Chris Packham <judge.packham@gmail.com> > > Your patches violate whitespace rules. Use 'git show --check' to see the > questionable lines. >
Will do. BTW theres no mention of --check in git show --help, but one itch at a time.
Show 10 quoted lines
>> --- >> I wasn't sure about the test numbering so I just grabbed the highest one. Still >> need to add tests for the deletion use case. > > According to t/README, t1* would be a suitable category, perhaps t1430. > >> t/t9800-git-alternate.sh | 95 ++++++++++++++++++++++++++++++++++++++++++++++ > > "git" in the name is redundant >
Is t1430-alternate-cmd.sh OK with everyone?
Show 5 quoted lines
>> +test_expect_success \ >> + 'Setup for rest of the test' ' > > The modern style for test headers is >
[snip]
Will incorporate in next update
Show 5 quoted lines
>> +#rm -rf A B C D base >> \ No newline at end of file > > test_done >
Ah, I knew it would be something simple like that. I guess I should have started by reading t/README.