git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Nov 2024, #06; Thu, 14)

From
Patrick Steinhardt <ps@pks.im>
Date
Nov 16, 2024, 11:24 UTC
Message-ID
<ZziAy187d_VU55QM@pks.im>
In-Reply-To
<xmqqy11kys9z.fsf@gitster.g>
On Sat, Nov 16, 2024 at 08:46:32AM +0900, Junio C Hamano wrote:
Show 10 quoted lines
> * ps/clar-build-improvement (2024-11-12) 4 commits
>  - Makefile: let clar header targets depend on their scripts
>  - cmake: use verbatim arguments when invoking clar commands
>  - cmake: use SH_EXE to execute clar scripts
>  - t/unit-tests: convert "clar-generate.awk" into a shell script
> 
>  Fix for clar unit tests to support CMake build.
> 
>  Will merge to 'next'?
>  source: <20241111-pks-clar-build-improvements-v2-0-d4794d8d1b30@pks.im>

I've sent a v3 yesterday that fixes a single commit message issue via [1]. That version should be ready for 'next'.

[1]: <20241115-pks-clar-build-improvements-v3-0-29672bf65ec6@pks.im>
Show 10 quoted lines
> * ps/send-pack-unhide-error-in-atomic-push (2024-11-14) 2 commits
>  - transport: don't ignore git-receive-pack(1) exit code on atomic push
>  - t5504: modernize test by moving heredocs into test bodies
> 
>  "git push --atomic --porcelain" used to ignore failures from the
>  other side, losing the error status from the child process, which
>  has been corrected.
> 
>  Comments?
>  source: <20241113-pks-push-atomic-respect-exit-code-v1-0-7965f01e7f4e@pks.im>

Jiang Xin has sent an alternative series that is more involved. I'll have a look at it.

Show 34 quoted lines
> * ps/leakfixes-part-10 (2024-11-13) 28 commits
>  - t: remove TEST_PASSES_SANITIZE_LEAK annotations
>  - test-lib: unconditionally enable leak checking
>  - t: remove unneeded !SANITIZE_LEAK prerequisites
>  - t: mark some tests as leak free
>  - t5601: work around leak sanitizer issue
>  - git-compat-util: drop now-unused `UNLEAK()` macro
>  - global: drop `UNLEAK()` annotation
>  - t/helper: fix leaking commit graph in "read-graph" subcommand
>  - builtin/branch: fix leaking sorting options
>  - builtin/init-db: fix leaking directory paths
>  - builtin/help: fix leaks in `check_git_cmd()`
>  - help: fix leaking return value from `help_unknown_cmd()`
>  - help: fix leaking `struct cmdnames`
>  - help: refactor to not use globals for reading config
>  - builtin/sparse-checkout: fix leaking sanitized patterns
>  - split-index: fix memory leak in `move_cache_to_base_index()`
>  - git: refactor builtin handling to use a `struct strvec`
>  - git: refactor alias handling to use a `struct strvec`
>  - strvec: introduce new `strvec_splice()` function
>  - line-log: fix leak when rewriting commit parents
>  - bisect: fix various cases where we leak commit list items
>  - bisect: fix leaking commit list items in `check_merge_base()`
>  - bisect: fix multiple leaks in `bisect_next_all()`
>  - bisect: fix leaking `current_bad_oid`
>  - bisect: fix leaking string in `handle_bad_merge_base()`
>  - bisect: fix leaking good/bad terms when reading multipe times
>  - builtin/blame: fix leaking blame entries with `--incremental`
>  - Merge branch 'ps/leakfixes-part-9' into ps/leakfixes-part-10
> 
>  Leakfixes.
> 
>  Will merge to 'next'?
>  source: <20241111-b4-pks-leak-fixes-pt10-v2-0-6154bf91f0b0@pks.im>

Rubén's review went through all of the patches and his findings have been addressed. The other comment from Peff seemed to only relate to dropping the use of `UNLEAK()`, so I don't think he had a full look at the patch series. So personally I don't plan to reroll this, but am not sure whether this had enough review exposure.

Patrick
Previous: Junio C HamanoNext: Rubén Justo
Message 4 of 8 in “What's cooking in git.git (Nov 2024, #06; Thu, 14)”
  1. Junio C HamanoNov 15, 2024
  2. Jeff KingNov 16, 2024
  3. Junio C HamanoNov 16, 2024
  4. Patrick SteinhardtNov 16, 2024
  5. Rubén JustoNov 16, 2024
  6. Patrick SteinhardtNov 18, 2024
  7. Rubén JustoNov 18, 2024
  8. Kristoffer HaugsbakkNov 16, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.