Re: [PATCH 00/26] Memory leak fixes (pt.10, final)

> On Wed, Nov 06, 2024 at 04:10:14PM +0100, Patrick Steinhardt wrote:
> > Hi,
> > 
> > this is the last part of my series of memory leak fixes. This series
> > goes a bit further than past series:
> > 
> >   - Patches 1 to 16 plug remaining memory leaks exposed by our test
> >     suite.
> > 
> >   - Patches 17 to 21 remove the last remaining `UNLEAK()` annotations
> >     and ultimately remove the macro itself.
> > 
> >   - Patch 22 works around a bug in the leak sanitizer itself.
> > 
> >   - Patches 23 and 24 drop annotations where leak-free tests pass with
> >     the leak sanitizer.
> > 
> >   - Patches 25 and 26 unconditionally enable leak checking in all newly
> >     added tests and then drop the `TEST_PASSES_SANITIZE_LEAK`
> >     annotation.
> 
> Hi Patrick.
> 
> Thanks for working on this.
> 
> It's been a while since 956d2e4639 (tests: add a test mode for SANITIZE=leak,
> run it in CI, 2021-09-23).  This series marks certainly another milestone.
> 
> I have left a few comments, none of them important.  The series looks
> good to me.  Just in case you re-roll, while reading the series I
> spotted some nits: